From 002fcf3b78c06b82611256f4e5fad72777bda4d6 Mon Sep 17 00:00:00 2001 From: Leroy Hopson Date: Fri, 26 Aug 2022 12:32:09 +1200 Subject: [PATCH] Remove deprecated cols/rows properties of Terminal --- addons/godot_xterm/terminal.gd | 29 ----------------------------- docs/CHANGELOG.md | 1 + docs/api/terminal.md | 28 ---------------------------- 3 files changed, 1 insertion(+), 57 deletions(-) diff --git a/addons/godot_xterm/terminal.gd b/addons/godot_xterm/terminal.gd index 7039ca8..f1d41e9 100644 --- a/addons/godot_xterm/terminal.gd +++ b/addons/godot_xterm/terminal.gd @@ -26,9 +26,6 @@ enum SelectionMode { export(UpdateMode) var update_mode = UpdateMode.AUTO setget set_update_mode -var cols = 2 setget _set_cols, _get_cols # Deprecated. -var rows = 2 setget _set_rows, _get_rows # Deprecated. - # If true, text in the terminal will be copied to the clipboard when selected. export(bool) var copy_on_selection @@ -70,36 +67,10 @@ func get_cols() -> int: return _cols -func _get_cols() -> int: - push_warning( - "The 'cols' property of Terminal is deprecated and will be removed in a future version. Please use the `get_cols()` method instead." - ) - return get_cols() - - -func _set_cols(_value) -> void: - push_error( - "The 'cols' property of Terminal is read-only and determined by rect_size and the theme's font size." - ) - - func get_rows() -> int: return _rows -func _get_rows() -> int: - push_warning( - "The 'rows' property of Terminal is deprecated and will be removed in a future version. Please use the `get_rows()` method instead." - ) - return get_rows() - - -func _set_rows(_value) -> void: - push_error( - "The 'rows' property of Terminal is read-only and determined by rect_size and the theme's font size." - ) - - func write(data) -> void: assert( data is PoolByteArray or data is String, diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 2ac6553..cc84240 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Removed - Removed support for deprecated theme item names. - Removed deprecated get_master() method of PTY. +- Removed deprecated cols/rows properties of Terminal. ## [v2.2.0](https://github.com/lihop/godot-xterm/compare/v2.1.1...v2.2.0) - 2022-08-26 diff --git a/docs/api/terminal.md b/docs/api/terminal.md index 8167bbc..e49da6c 100644 --- a/docs/api/terminal.md +++ b/docs/api/terminal.md @@ -47,8 +47,6 @@ For example if the string `"\u001b[38;2;0;255;0;mA"` was written to the terminal |--------------|--------------------------------------|---------| | [bool] | [bell_muted](#prop-bell_muted) | `false` | | [float] | [bell_cooldown](#prop-bell_cooldown) | `0.1` | -| [int] | [cols](#prop-cols) *(deprecated)* | `2` | -| [int] | [rows](#prop-rows) *(deprecated)* | `2` | | [UpdateMode] | [update_mode](#prop-update_mode) | `AUTO` | @@ -108,32 +106,6 @@ For example if the string `"\u001b[38;2;0;255;0;mA"` was written to the terminal ## Property Descriptions -- [int] **cols** - - | | | - |-----------|------------| - | *Default* | `2` | - | *Setter* | None | - | *Getter* | get_cols() | - - *Deprecated*. This property is deprecated and will be removed in a future version. - Please use [get_cols](#mthd-get_cols) instead. - ---- - -- [int] **rows** ***Deprecated*** - - | | | - |-----------|------------| - | *Default* | `2` | - | *Setter* | None | - | *Getter* | get_rows() | - - *Deprecated*. This property is deprecated and will be removed in a future version. - Please use the [get_rows](#mthd-get_rows) instead. - ---- - - [bool] **bell_muted** | | |