From 26ad5c0810627e7db2c64000200911426d81e539 Mon Sep 17 00:00:00 2001 From: Alexander Treml Date: Fri, 27 Jun 2025 16:37:45 +0200 Subject: [PATCH] pty hotfix to not crash godot when exiting tree --- addons/godot_xterm/native/src/pty_win.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/addons/godot_xterm/native/src/pty_win.cpp b/addons/godot_xterm/native/src/pty_win.cpp index 4be8bef..9087df4 100644 --- a/addons/godot_xterm/native/src/pty_win.cpp +++ b/addons/godot_xterm/native/src/pty_win.cpp @@ -189,10 +189,9 @@ Dictionary PTYWin::open( void PTYWin::close(uint64_t hpc, int fd, int fd_out) { - ClosePseudoConsole(reinterpret_cast(hpc)); - // TODO(ast) this causes assertion errors. Might be related to this: https://stackoverflow.com/questions/5984144/assertion-error-in-crt-calling-osfile-in-vs-2008 // TODO(ast) leave for now and return when the linking issues are figured out (see SConstruct file) + // ClosePseudoConsole(reinterpret_cast(hpc)); // // Drain remaining data // char drain_buf[4096]; // int bytes_read = 0;