Jasima/godot-xterm
1
0
Fork 0
mirror of https://github.com/lihop/godot-xterm.git synced 2024-11-10 04:40:25 +01:00
Code Issues Projects Releases Packages Wiki Activity

Use alloc_c_string() to convert String to char*

Browse source 
Using get_data() would sometimes result in the wrong data being written.

Fixes #12
This commit is contained in:
Leroy Hopson 2020-11-07 17:12:31 +07:00 committed by Leroy Hopson
parent 43df7d5331
commit 399acf00c7
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
CHANGELOG.md
View file

@ -13,6 +13,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Positioned background rect at 0,0 so it is no longer offset if a margin is added when Terminal is a child of a Container node. - Positioned background rect at 0,0 so it is no longer offset if a margin is added when Terminal is a child of a Container node.
- Removed all pre-compiled binaries using BFG [Repo-Cleaner](https://rtyley.github.io/bfg-repo-cleaner/), thus re-writing git history. - Removed all pre-compiled binaries using BFG [Repo-Cleaner](https://rtyley.github.io/bfg-repo-cleaner/), thus re-writing git history.
### Fixed
- Fixed #12 where incorrect data would sometimes be written to the terminal when passing a string to the Terminal's `write()` method.
## [1.0.0] - 2020-10-05 ## [1.0.0] - 2020-10-05
### Added ### Added
- Changelog. - Changelog.

5
addons/godot_xterm/native/src/terminal.cpp
View file

@ -585,9 +585,8 @@ void Terminal::write(Variant data)
case Variant::Type::STRING: case Variant::Type::STRING:
{ {
String string = data; String string = data;
CharString utf8 = string.utf8(); u8 = string.alloc_c_string();
u8 = utf8.get_data(); len = strlen(u8);
len = utf8.length();
break; break;
} }
default: default: