From 41525959e10360614ed1df7cd8148b495d9de09f Mon Sep 17 00:00:00 2001 From: Leroy Hopson Date: Fri, 19 Aug 2022 20:20:04 +1200 Subject: [PATCH] Deprecate undocumented get_master() method This method was never officially documented and used only as a workaround for issue #53. It also returns an instance of the undocumented and scruffily implemented Pipe class that I would prefer to keep internal. Now that #53 has been fixed, this method can be removed from the unofficial public API, but deprecate it just in case. If someone was using it then it is still possible (although not supported) to access the `_pipe` property of `_pty_native`. --- addons/godot_xterm/pty.gd | 3 +++ 1 file changed, 3 insertions(+) diff --git a/addons/godot_xterm/pty.gd b/addons/godot_xterm/pty.gd index 2126073..44d9b2f 100644 --- a/addons/godot_xterm/pty.gd +++ b/addons/godot_xterm/pty.gd @@ -173,6 +173,9 @@ func open(cols: int = DEFAULT_COLS, rows: int = DEFAULT_ROWS) -> Array: func get_master(): + push_warning( + "The method get_master() is deprecated and will be removed in a future version. If you really need to get the underlying Pipe of the pty, then you can access '_pty_native._pipe', but this is not supported and may change at any time." + ) return _pty_native.get_master()