From 46f3aa12bf0b6e7dbe6e072f5ad804ec225558e6 Mon Sep 17 00:00:00 2001
From: Leroy Hopson <git@leroy.geek.nz>
Date: Sat, 2 Mar 2024 21:51:24 +1300
Subject: [PATCH] chore(ci): enable debug symbols for debug builds

Exclude Windows as it leads to a "warning LNK4099: PDB '' was not found
with 'constants.windows.template_debug.x86_64.obj' or at ''" error on
subsequent runs.
---
 .github/workflows/main.yml                   | 2 +-
 addons/godot_xterm/native/docker-compose.yml | 7 ++++++-
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index e8cac87..20017c9 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -160,7 +160,7 @@ jobs:
           SCONS_CACHE: ${{github.workspace}}/.scons-cache
         run: |
           cd addons/godot_xterm/native
-          scons platform=${{ matrix.platform }} target=template_${{ matrix.target }} arch=${{ matrix.arch }} -j2
+          scons platform=${{ matrix.platform }} target=template_${{ matrix.target }} arch=${{ matrix.arch }} debug_symbols=${{ matrix.platform != 'windows' && matrix.target == 'debug' && 'yes' || 'no' }} -j2
       - name: Upload binaries
         uses: actions/upload-artifact@v4
         with:
diff --git a/addons/godot_xterm/native/docker-compose.yml b/addons/godot_xterm/native/docker-compose.yml
index 4298de6..81f0b1a 100644
--- a/addons/godot_xterm/native/docker-compose.yml
+++ b/addons/godot_xterm/native/docker-compose.yml
@@ -56,4 +56,9 @@ services:
       - /bin/bash
       - -c
       - |
-        scons target=template_$${TARGET:-debug} arch=$${ARCH:-x86_64}
+        if [ -z "$$DEBUG_SYMBOLS" ]; then
+          if [ "$$TARGET" == "debug" ]; then
+            DEBUG_SYMBOLS=yes
+          fi
+        fi
+        scons target=template_$${TARGET:-debug} arch=$${ARCH:-x86_64} debug_symbols=$${DEBUG_SYMBOLS:-no}