From 7f03761fb2119a63ae584157761f7d9dcf4daa48 Mon Sep 17 00:00:00 2001 From: Leroy Hopson Date: Sun, 3 Mar 2024 18:12:25 +1300 Subject: [PATCH] fix(pty): remove non-portable signal enums Remove signal enum members which do not use portable numbers, and therefore may be different on different operating systems. --- addons/godot_xterm/native/src/pty.cpp | 3 --- addons/godot_xterm/native/src/pty.h | 3 --- test/test_pty.gd | 1 - 3 files changed, 7 deletions(-) diff --git a/addons/godot_xterm/native/src/pty.cpp b/addons/godot_xterm/native/src/pty.cpp index c366338..740526c 100644 --- a/addons/godot_xterm/native/src/pty.cpp +++ b/addons/godot_xterm/native/src/pty.cpp @@ -37,12 +37,9 @@ void PTY::_bind_methods() { BIND_ENUM_CONSTANT(SIGNAL_SIGILL); BIND_ENUM_CONSTANT(SIGNAL_SIGTRAP); BIND_ENUM_CONSTANT(SIGNAL_SIGABRT); - BIND_ENUM_CONSTANT(SIGNAL_SIGBUS); BIND_ENUM_CONSTANT(SIGNAL_SIGFPE); BIND_ENUM_CONSTANT(SIGNAL_SIGKILL); - BIND_ENUM_CONSTANT(SIGNAL_SIGUSR1); BIND_ENUM_CONSTANT(SIGNAL_SIGSEGV); - BIND_ENUM_CONSTANT(SIGNAL_SIGUSR2); BIND_ENUM_CONSTANT(SIGNAL_SIGPIPE); BIND_ENUM_CONSTANT(SIGNAL_SIGALRM); BIND_ENUM_CONSTANT(SIGNAL_SIGTERM); diff --git a/addons/godot_xterm/native/src/pty.h b/addons/godot_xterm/native/src/pty.h index 4c9e2a6..4b3e8f9 100644 --- a/addons/godot_xterm/native/src/pty.h +++ b/addons/godot_xterm/native/src/pty.h @@ -24,12 +24,9 @@ namespace godot SIGNAL_SIGILL = 4, SIGNAL_SIGTRAP = 5, SIGNAL_SIGABRT = 6, - SIGNAL_SIGBUS = 7, SIGNAL_SIGFPE = 8, SIGNAL_SIGKILL = 9, - SIGNAL_SIGUSR1 = 10, SIGNAL_SIGSEGV = 11, - SIGNAL_SIGUSR2 = 12, SIGNAL_SIGPIPE = 13, SIGNAL_SIGALRM = 14, SIGNAL_SIGTERM = 15, diff --git a/test/test_pty.gd b/test/test_pty.gd index d08762b..1fd1b55 100644 --- a/test/test_pty.gd +++ b/test/test_pty.gd @@ -66,7 +66,6 @@ class TestInterface: # Enums. - # Added SIGNAL_ prefix to name. func test_has_enum_signal(): assert_eq(described_class.SIGNAL_SIGHUP, 1) assert_eq(described_class.SIGNAL_SIGINT, 2)