From 8d656d8c711f88a6b0d66f6c45e71d1d896c799a Mon Sep 17 00:00:00 2001 From: Leroy Hopson Date: Fri, 26 Aug 2022 12:35:13 +1200 Subject: [PATCH] Remove deprecated get_master() method of PTY --- addons/godot_xterm/nodes/pty/pty_native.gd | 4 ---- addons/godot_xterm/nodes/pty/unix/pty_unix.gd | 6 ------ addons/godot_xterm/pty.gd | 7 ------- docs/CHANGELOG.md | 1 + 4 files changed, 1 insertion(+), 17 deletions(-) diff --git a/addons/godot_xterm/nodes/pty/pty_native.gd b/addons/godot_xterm/nodes/pty/pty_native.gd index 8c1e27a..41dfde7 100644 --- a/addons/godot_xterm/nodes/pty/pty_native.gd +++ b/addons/godot_xterm/nodes/pty/pty_native.gd @@ -13,10 +13,6 @@ func resize(cols: int, rows: int): return _not_implemented() -func get_master(): - return _not_implemented() - - func _not_implemented() -> int: var method := "" diff --git a/addons/godot_xterm/nodes/pty/unix/pty_unix.gd b/addons/godot_xterm/nodes/pty/unix/pty_unix.gd index 789c143..f59364c 100644 --- a/addons/godot_xterm/nodes/pty/unix/pty_unix.gd +++ b/addons/godot_xterm/nodes/pty/unix/pty_unix.gd @@ -166,12 +166,6 @@ func open(cols: int = DEFAULT_COLS, rows: int = DEFAULT_ROWS) -> Array: return PTYUnix.new().open(cols, rows) -func get_master(): - if _pipe: - return _pipe - return null - - func _exit_tree(): _exit_cb = null if _pid > 1: diff --git a/addons/godot_xterm/pty.gd b/addons/godot_xterm/pty.gd index 44d9b2f..686bae3 100644 --- a/addons/godot_xterm/pty.gd +++ b/addons/godot_xterm/pty.gd @@ -172,13 +172,6 @@ func open(cols: int = DEFAULT_COLS, rows: int = DEFAULT_ROWS) -> Array: return _pty_native.open(cols, rows) -func get_master(): - push_warning( - "The method get_master() is deprecated and will be removed in a future version. If you really need to get the underlying Pipe of the pty, then you can access '_pty_native._pipe', but this is not supported and may change at any time." - ) - return _pty_native.get_master() - - func _on_pty_native_data_received(data): emit_signal("data_received", data) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 2fda78e..2ac6553 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased](https://github.com/lihop/godot-xterm/compare/v2.2.0...HEAD) ### Removed - Removed support for deprecated theme item names. +- Removed deprecated get_master() method of PTY. ## [v2.2.0](https://github.com/lihop/godot-xterm/compare/v2.1.1...v2.2.0) - 2022-08-26