From ef9e96ed13a85e70a948d9ff05a7dada620742ba Mon Sep 17 00:00:00 2001 From: Leroy Hopson Date: Wed, 1 Jun 2022 11:50:34 +0700 Subject: [PATCH] Remove custom TerminalSettings Resource type There is no current public use for this type and it would appear in every resource dropdown. While this type is no longer exposed publically by the plugin it is still used internally by terminal_panel. --- CHANGELOG.md | 6 ++++++ addons/godot_xterm/plugin.gd | 3 --- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a82d6a0..f934a4b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,11 +17,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 required GLIBC version is now 2.17 which was released in 2012. - Target Godot version from 3.3.2-stable -> 3.4.4-stable. +### Removed +- Removed custom TerminalSettings Resource type. + This Resource was not being used but would still appear in every resource dropdown. + Related issue [godotengine/godot#24643](https://github.com/godotengine/godot/issues/24643). + ### Fixed - The `kill()` method of unix PTY node can now be called without error as the underlying `pipe.close()` method of the gdnative library is now registered. + ## [v2.0.0](https://github.com/lihop/godot-xterm/compare/v1.2.1...v2.0.0) - 2021-07-25 ### Added - Terminal editor plugin. Adds integrated terminal to Godot editor. diff --git a/addons/godot_xterm/plugin.gd b/addons/godot_xterm/plugin.gd index 608e0e7..7b6cd4c 100644 --- a/addons/godot_xterm/plugin.gd +++ b/addons/godot_xterm/plugin.gd @@ -29,8 +29,6 @@ func _enter_tree(): "X11", "Server", "OSX": pty_script = load("%s/nodes/pty/pty.gd" % base_dir) add_custom_type("PTY", "Node", pty_script, pty_icon) - var terminal_settings_script = preload("./editor_plugins/terminal/settings/terminal_settings.gd") - add_custom_type("TerminalSettings", "Resource", terminal_settings_script, null) terminal_panel = preload("./editor_plugins/terminal/terminal_panel.tscn").instance() terminal_panel.editor_plugin = self terminal_panel.editor_interface = get_editor_interface() @@ -49,6 +47,5 @@ func _exit_tree(): if pty_supported: remove_custom_type("PTY") - remove_custom_type("TerminalSettings") remove_control_from_bottom_panel(terminal_panel) terminal_panel.free()