Jasima/godot-xterm
1
0
Fork 0
mirror of https://github.com/lihop/godot-xterm.git synced 2024-09-20 00:26:18 +02:00
Code Issues Projects Releases Packages Wiki Activity

Remove deprecated cols/rows properties of Terminal

Browse source
This commit is contained in:
Leroy Hopson 2022-08-26 12:32:09 +12:00
parent 8d656d8c71
commit 002fcf3b78
No known key found for this signature in database
GPG key ID: D2747312A6DB51AA
3 changed files with 1 additions and 57 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
addons/godot_xterm/terminal.gd
View file

@ -26,9 +26,6 @@ enum SelectionMode {
export(UpdateMode) var update_mode = UpdateMode.AUTO setget set_update_mode
var cols = 2 setget _set_cols, _get_cols # Deprecated.
var rows = 2 setget _set_rows, _get_rows # Deprecated.
# If true, text in the terminal will be copied to the clipboard when selected.
export(bool) var copy_on_selection
@ -70,36 +67,10 @@ func get_cols() -> int:
return _cols
func _get_cols() -> int:
push_warning(
"The 'cols' property of Terminal is deprecated and will be removed in a future version. Please use the `get_cols()` method instead."
)
return get_cols()
func _set_cols(_value) -> void:
push_error(
"The 'cols' property of Terminal is read-only and determined by rect_size and the theme's font size."
)
func get_rows() -> int:
return _rows
func _get_rows() -> int:
push_warning(
"The 'rows' property of Terminal is deprecated and will be removed in a future version. Please use the `get_rows()` method instead."
)
return get_rows()
func _set_rows(_value) -> void:
push_error(
"The 'rows' property of Terminal is read-only and determined by rect_size and the theme's font size."
)
func write(data) -> void:
assert(
data is PoolByteArray or data is String,

1
docs/CHANGELOG.md
View file

@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Removed
- Removed support for deprecated theme item names.
- Removed deprecated get_master() method of PTY.
- Removed deprecated cols/rows properties of Terminal.
## [v2.2.0](https://github.com/lihop/godot-xterm/compare/v2.1.1...v2.2.0) - 2022-08-26

28
docs/api/terminal.md
View file

@ -47,8 +47,6 @@ For example if the string `"\u001b[38;2;0;255;0;mA"` was written to the terminal
|--------------|--------------------------------------|---------|
| [bool] | [bell_muted](#prop-bell_muted) | `false` |
| [float] | [bell_cooldown](#prop-bell_cooldown) | `0.1` |
| [int] | [cols](#prop-cols) *(deprecated)* | `2` |
| [int] | [rows](#prop-rows) *(deprecated)* | `2` |
| [UpdateMode] | [update_mode](#prop-update_mode) | `AUTO` |
@ -108,32 +106,6 @@ For example if the string `"\u001b[38;2;0;255;0;mA"` was written to the terminal
## Property Descriptions
- <a name="prop-cols" /> [int] **cols**
| | |
|-----------|------------|
| *Default* | `2` |
| *Setter* | None |
| *Getter* | get_cols() |
*Deprecated*. This property is deprecated and will be removed in a future version.
Please use [get_cols](#mthd-get_cols) instead.
---
- <a name="prop-rows" /> [int] **rows** ***Deprecated***
| | |
|-----------|------------|
| *Default* | `2` |
| *Setter* | None |
| *Getter* | get_rows() |
*Deprecated*. This property is deprecated and will be removed in a future version.
Please use the [get_rows](#mthd-get_rows) instead.
---
- <a name="prop-bell_muted" /> [bool] **bell_muted**
| | |