Jasima/godot-xterm
1
0
Fork 0
mirror of https://github.com/lihop/godot-xterm.git synced 2025-06-28 18:25:31 +02:00
Code Issues Projects Releases Packages Wiki Activity

pty hotfix to not crash godot when exiting tree

Browse source
This commit is contained in:
Alexander Treml 2025-06-27 16:37:45 +02:00 • committed by Leroy Hopson
parent f3820365c6
commit 26ad5c0810
No known key found for this signature in database
GPG key ID: D2747312A6DB51AA
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
addons/godot_xterm/native/src/pty_win.cpp
View file

@ -189,10 +189,9 @@ Dictionary PTYWin::open(
void PTYWin::close(uint64_t hpc, int fd, int fd_out)
{
ClosePseudoConsole(reinterpret_cast<HPCON>(hpc));
// TODO(ast) this causes assertion errors. Might be related to this: https://stackoverflow.com/questions/5984144/assertion-error-in-crt-calling-osfile-in-vs-2008
// TODO(ast) leave for now and return when the linking issues are figured out (see SConstruct file)
// ClosePseudoConsole(reinterpret_cast<HPCON>(hpc));
// // Drain remaining data
// char drain_buf[4096];
// int bytes_read = 0;