Jasima/godot-xterm
1
0
Fork 0
mirror of https://github.com/lihop/godot-xterm.git synced 2024-11-24 10:20:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Remove custom TerminalSettings Resource type

Browse source 
There is no current public use for this type and it would appear in every
resource dropdown.

While this type is no longer exposed publically by the plugin it is still
used internally by terminal_panel.
This commit is contained in:
Leroy Hopson 2022-06-01 11:50:34 +07:00
parent fde082a88f
commit ef9e96ed13
No known key found for this signature in database
GPG key ID: D2747312A6DB51AA
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
CHANGELOG.md
View file

@ -17,11 +17,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
required GLIBC version is now 2.17 which was released in 2012. required GLIBC version is now 2.17 which was released in 2012.
- Target Godot version from 3.3.2-stable -> 3.4.4-stable. - Target Godot version from 3.3.2-stable -> 3.4.4-stable.
### Removed
- Removed custom TerminalSettings Resource type.
This Resource was not being used but would still appear in every resource dropdown.
Related issue [godotengine/godot#24643](https://github.com/godotengine/godot/issues/24643).
### Fixed ### Fixed
- The `kill()` method of unix PTY node can now be called without error as the underlying - The `kill()` method of unix PTY node can now be called without error as the underlying
`pipe.close()` method of the gdnative library is now registered. `pipe.close()` method of the gdnative library is now registered.
## [v2.0.0](https://github.com/lihop/godot-xterm/compare/v1.2.1...v2.0.0) - 2021-07-25 ## [v2.0.0](https://github.com/lihop/godot-xterm/compare/v1.2.1...v2.0.0) - 2021-07-25
### Added ### Added
- Terminal editor plugin. Adds integrated terminal to Godot editor. - Terminal editor plugin. Adds integrated terminal to Godot editor.

3
addons/godot_xterm/plugin.gd
View file

@ -29,8 +29,6 @@ func _enter_tree():
"X11", "Server", "OSX": "X11", "Server", "OSX":
pty_script = load("%s/nodes/pty/pty.gd" % base_dir) pty_script = load("%s/nodes/pty/pty.gd" % base_dir)
add_custom_type("PTY", "Node", pty_script, pty_icon) add_custom_type("PTY", "Node", pty_script, pty_icon)
var terminal_settings_script = preload("./editor_plugins/terminal/settings/terminal_settings.gd")
add_custom_type("TerminalSettings", "Resource", terminal_settings_script, null)
terminal_panel = preload("./editor_plugins/terminal/terminal_panel.tscn").instance() terminal_panel = preload("./editor_plugins/terminal/terminal_panel.tscn").instance()
terminal_panel.editor_plugin = self terminal_panel.editor_plugin = self
terminal_panel.editor_interface = get_editor_interface() terminal_panel.editor_interface = get_editor_interface()
@ -49,6 +47,5 @@ func _exit_tree():
if pty_supported: if pty_supported:
remove_custom_type("PTY") remove_custom_type("PTY")
remove_custom_type("TerminalSettings")
remove_control_from_bottom_panel(terminal_panel) remove_control_from_bottom_panel(terminal_panel)
terminal_panel.free() terminal_panel.free()